Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #38 , updating the user properties didn't work previously.
In the user upsert function,
notifo/backend/src/Notifo.Domain/Users/UpsertUser.cs
Line 53 in 86cfa08
The properties are meant to be kept in the
Properties
fieldnotifo/backend/src/Notifo.Domain/Users/UpsertUser.cs
Lines 84 to 90 in 86cfa08
While on the front-end side, the properties are sent directly at the "root" level of the DTO, e.g. here's an example POST request
That's because the form properties weren't registered inside "properties", but rather at the root level of the DTO.
On the other hand, the DTO on front-end is correct and assumes the properties are kept in the
properties
fieldnotifo/frontend/src/app/service/service.ts
Lines 6622 to 6623 in 86cfa08
This pull request contains the fixes for this.