Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File support for update command #23

Open
limejet opened this issue Aug 25, 2023 · 3 comments
Open

File support for update command #23

limejet opened this issue Aug 25, 2023 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@limejet
Copy link

limejet commented Aug 25, 2023

I use local packs for my server since i distribute mods with automodpack rather than by having people download the pack manually. I have a script that runs mrpack-install latest-pack.mrpack on every restart, and this worked until i replaced a mod with a mutually incompatible one. it was at this point i realized that the program only deletes files when running update, and that the update command has no code path for files. Could this capability be added?

@nothub
Copy link
Owner

nothub commented Sep 8, 2023

I am not sure if I understand correctly.

You replaced a mod with a mutually incompatible one. You mean mutually incompatible by definition of the mods in their respective mod configuration files?

the program only deletes files when running update, and that the update command has no code path for files

I am also not sure if I understand this correctly. What do you mean with :

the program only deletes files when running update, and that the update command has no code path for files

Could you describe what you suspected the tool to do and what it actually did?

@limejet
Copy link
Author

limejet commented Sep 11, 2023

What i expected to happen when running mrpack-install /path/to/my-pack.mrpack on an existing instance was that the tool would make the installation match the mrpack specification by removing mods and configs not included in the pack definition. Instead, it just installs on top, leaving old files as they were.

My understanding for update was that maybe a normal install would not care about existing files but an update would, but now that i'm reading through the docs i realize that's now what it does. The name of the issue is a consequence of my misunderstanding.

@nothub nothub added enhancement New feature or request question Further information is requested labels Oct 31, 2023
@nothub
Copy link
Owner

nothub commented Oct 31, 2023

Hey @limejet , sorry that I took so long to answer here.
What you are describing makes me wonder if the current update command workflow was ever implemented in a sane way 🙈

I am in the process of rewriting the update workflow currently.
I have described the planned behaviour in : #39

Mods that were included in the packs definition in the past but are not included anymore when the update command is run should be removed from the mods directory. From what I wrote in #39, this is also what I had in mind.

The workflow in #39 is not finalized yet and is still subject to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants