Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not properly encode '+' in url through browser #196

Open
Kriegbaum opened this issue Jun 23, 2021 · 2 comments
Open

Does not properly encode '+' in url through browser #196

Kriegbaum opened this issue Jun 23, 2021 · 2 comments

Comments

@Kriegbaum
Copy link

When accessing an album through the library browser, ympd does not properly encode the + character into the url.

Example:
http://10.0.0.55:8080/#/browse/0/The%20Walkmen/Bows%20+%20Arrows
Is the URL generated when I attempt to access the walkmen album "Bows + Arrows"
This results in an empty tracklist

Manually punching in:
http://10.0.0.55:8080/#/browse/0/The%20Walkmen/Bows%20%2b%20Arrows
Displays a proper tracklist for the album

@SuperBFG7
Copy link
Contributor

Wow, indeed. Interesting nobody ever noticed this before.
I've fixed this in my fork by using encodeURIComponent() instead of encodeURI(): 7b5496e

@Kriegbaum
Copy link
Author

Haha, after opening this issue, I realized this project isnt really being maintained anymore and tried out myMpd. It's got a similar but slightly different URL encoding bug as well. I'll make a pull request on that one if I ever get the time to look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants