Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please implement the 'parent' property? #26

Open
focussing opened this issue Apr 25, 2018 · 2 comments
Open

Could you please implement the 'parent' property? #26

focussing opened this issue Apr 25, 2018 · 2 comments

Comments

@focussing
Copy link

focussing commented Apr 25, 2018

I tried, but when I edit the source code in the node_modules folder it does not work...
Maybe you can tell me how to do that?
Or put in a prop which sets the vertical offset?

@focussing
Copy link
Author

If I try to run dist I get the following error;

iMac:vue-easy-toast raymond$ npm run dist

[email protected] dist /Users/raymond/stack/sites/monsteragenda/node_modules/vue-easy-toast
cross-env NODE_ENV=production webpack --progress --hide-modules

10% [1] building modules 3/3 modules 0 active(node:30667) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
[1] Hash: 765c87d6243a113b16b06f7c348e538eef0a330d
Version: webpack 2.7.0
Child
Hash: 765c87d6243a113b16b0
Time: 1913ms
Asset Size Chunks Chunk Names
vue-easy-toast.min.js 35.7 kB 0 [emitted] main
vue-easy-toast.min.js.map 51.1 kB 0 [emitted] main

ERROR in vue-easy-toast.min.js from UglifyJs
Unexpected token: punc (() [./src/index.js:5,0][vue-easy-toast.min.js:1227,9]

Child
Hash: 6f7c348e538eef0a330d
Time: 2007ms
Asset Size Chunks Chunk Names
vue-easy-toast-lite.min.js 24.4 kB 0 [emitted] main
vue-easy-toast.css 1.69 kB 0 [emitted] main
vue-easy-toast-lite.min.js.map 36.2 kB 0 [emitted] main
vue-easy-toast.css.map 95 bytes 0 [emitted] main

ERROR in vue-easy-toast-lite.min.js from UglifyJs
Unexpected token: punc (() [./src/index.js:5,0][vue-easy-toast-lite.min.js:870,9]

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] dist: cross-env NODE_ENV=production webpack --progress --hide-modules
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] dist script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/raymond/.npm/_logs/2018-04-25T17_33_12_500Z-debug.log

@noru
Copy link
Owner

noru commented May 9, 2018

@focussing
The 'parent' property should work as https://github.com/noru/vue-easy-toast/blob/master/src/index.js#L15 shows

and I tried to remove 'node_modules' and reinstall all packages then npm run dist, no errors pop up.

Would you please submit your changes in a PR, so I can understand the problem further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants