-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show keybindings in smex results. #55
Open
Wilfred
wants to merge
5
commits into
nonsequitur:master
Choose a base branch
from
Wilfred:show-keybindings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wilfred
added a commit
to Wilfred/.emacs.d
that referenced
this pull request
Nov 14, 2015
Upstream pull request: nonsequitur/smex#55
Getting keybindings is relatively slow (a few seconds), so we only update keybindings when Emacs is idle. We repurpose `smex-auto-update` for this, as it's currently unused.
Wilfred
force-pushed
the
show-keybindings
branch
from
November 25, 2015 09:00
b88f45e
to
70dee6f
Compare
Wilfred
added a commit
to Wilfred/.emacs.d
that referenced
this pull request
Nov 25, 2015
This fixes performance of running smex. See nonsequitur/smex#55 for the source.
This is absolutely great and will make me switch to ido + smex ! |
+1 - exactly what I'm missing from smex :) |
same here - as a new emacs user im really missing this - this implementation looks perfect too |
This would be great. The one thing I miss when using smex. |
15 tasks
Show keybindings in smex results.
…g sure it runs in the background for the first time
Improving keybinding presentation patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result looks like this:
A neat consequence of this is that you can filter by keybindings, not just command names:
Do let me know what you think. I often forget keybindings and would find this very helpful.
Closes #53.