Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for touch using jquery-ui-touch-punch #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for touch using jquery-ui-touch-punch #141

wants to merge 1 commit into from

Conversation

Tadaboody
Copy link

Fixes #128 by using https://github.com/furf/jquery-ui-touch-punch

Tested locally by using chrome dev tools on mobile mode and using the website on an iPad.

The website still isn't super responsive on mobile (zoom in doesn't work, connections are very hard to draw) but this is a great first step ^_^

nomeata
nomeata reviewed Jan 6, 2024
View reviewed changes
Copy link
Owner

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

You say that it’s not great yet. But do you think it’s actually usable enough now on touch devices, or just a bit less broken?

install-jslibs.sh
@@ -13,6 +13,8 @@ test -d jquery-ui || {
mv jquery-ui-1.11.4 jquery-ui
rm -f jquery-ui-1.11.4.zip
}
test -e jquery.ui.touch-punch.min.js ||
wget -c https://raw.githubusercontent.com/furf/jquery-ui-touch-punch/master/jquery.ui.touch-punch.min.js
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a versioned URL we can use here?

@nomeata
Copy link
Owner

nomeata commented Jan 6, 2024

We should maybe collect a list of thing that don’t work (yet) with touch.

  • Panning doesn’t work either, it seems (Firefox Dev Tools).
  • Shift-Tab to select also doesn’t seem to work.
  • Custom blocks cannot be resized; the interaction that resizes them with the mouse only moves them (probably needs to listen to more events in webui/incredible-elements.js)
  • And of course all hover functionality is somewhat broken. You can still delete blocks if you know where to click. If we’d want to make this touch friendly properly, we’d have to rethink all hover-based interaction. Maybe long-touch to select blocks and connections, and a 🗑️ button in the button bar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata nomeata left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No obvious way to add blocks on mobile
2 participants
@Tadaboody @nomeata