-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module logger #141
Comments
the parse function takes in the logger as arg which should be passed on to other functions. i usually make it as class attrb. you can also define it as var in the module in some cases |
The only solution is to share the same logger object among functions. That would be either a decorator or a class attribute, as Alvin suggested. |
Let me first merge my branch before overhauling the schema at this scale, though. |
Ok, I think class attribute is the most consistent one. I will fix it elsewhere later. |
Indeed, and if you apply it as a class decorator, your implementation will be more modular. How you prefer. |
Why a class decorator? I think an input to each class |
Please don't move it to the |
@ladinesa @ndaelman-hu I have a question regarding the logger. Right now, I was passing it as an input of our functions, but I realize this might not be the best practice.
Do you know what is the best way of handling this? Define it in the class or in the modules?
The text was updated successfully, but these errors were encountered: