Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #126

Open
5 of 8 tasks
JosePizarro3 opened this issue Sep 23, 2024 · 4 comments
Open
5 of 8 tasks

Minor fixes #126

JosePizarro3 opened this issue Sep 23, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@JosePizarro3
Copy link
Collaborator

JosePizarro3 commented Sep 23, 2024

While I was debugging using the Wannier90 parser, I got some errors to be fixed (see nomad-parser-wannier90#3):

  • Change order of normalization for 1st KSpace and then its subsections (KMesh and KLinePath).
  • Fix warning in spectral_profile.py adding condition for if self.name == 'ElectronicDensityOfStates' for total DOS.
  • Overwrite FermiLevel and call for ElectronicBandStructure.normalize() once DFT+TB workflow is resolved.
  • No idea why, but in the frontend, the SinglePoint.inputs and outputs section are not shown.
  • Fix README
  • Fix equality operator
  • Move testing files to subfolders to mimic the src structure
  • Delete copyright at the beginning of each file
@JosePizarro3 JosePizarro3 added the bug Something isn't working label Sep 23, 2024
@JosePizarro3 JosePizarro3 self-assigned this Sep 23, 2024
@JosePizarro3
Copy link
Collaborator Author

@ladinesa (once you feel better): can you tell me your thoughts on the first todo point regarding the order of calling normalize? I can explain more in detail (but you can also read the issue in the parser).

Also, the last point: I do not know why, but the SinglePoint links for inputs and outputs, the reference section is not showing on the front end:

Screenshot from 2024-09-23 16-10-28

It only happens for Input Model System and Outputs, but for Input Model Method is properly showing, see:

Screenshot from 2024-09-23 16-11-18

Any ideas what is going on wrong? I can share some branch with you to test.

@JosePizarro3 JosePizarro3 linked a pull request Sep 24, 2024 that will close this issue
@JosePizarro3 JosePizarro3 removed a link to a pull request Sep 24, 2024
@ladinesa
Copy link
Collaborator

Any ideas what is going on wrong? I can share some branch with you to test.

Did you generate the gui artifacts? it could be that the definition is simply not loaded.

@JosePizarro3
Copy link
Collaborator Author

Yeah I did, but I can double check again (or maybe do before ctrl+f5...). ModelMethod seems to be working.

@ladinesa
Copy link
Collaborator

@ladinesa (once you feel better): can you tell me your thoughts on the first todo point regarding the order of calling normalize? I can explain more in detail (but you can also read the issue in the parser).

You could also try to normalize 'reciprocal_lattice_vectors' in the sub-section, and put an if in the main section if this is already normalized. You can isolate the normalize function for the reciprocal lattice vector so you can easily call it in the child section, something like self.m_parent.normalize_reciprocal_lattice_vector(..). The current normalizer level applies only for the sub sections in a section but I am not sure how we can do this to order generally and if this makes sense.

@JFRudzinski JFRudzinski added this to the 1.0.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants