Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving simulation workflow definitions to this repo #100

Open
JosePizarro3 opened this issue Jul 15, 2024 · 9 comments
Open

Moving simulation workflow definitions to this repo #100

JosePizarro3 opened this issue Jul 15, 2024 · 9 comments
Assignees
Labels
new feature New feature or request
Milestone

Comments

@JosePizarro3
Copy link
Collaborator

JosePizarro3 commented Jul 15, 2024

@ladinesa and the others (@JFRudzinski @ndaelman-hu @Bernadette-Mohr)

I would like to start moving the SimulationWorkflow definitions here, under a sub-folder workflow in the schema packages defs of this package.

I also encountered some issues when releasing the Wannier90 parser in pypi and trying to add the current nomad-simulation-workflow-schema-plugin as it does not have a released version. In any case, this would be solved now if we moved everything here.

As a reference, this is the repo I will be transfering: https://github.com/nomad-coe/nomad-schema-plugin-simulation-workflow

@JosePizarro3 JosePizarro3 added the new feature New feature or request label Jul 15, 2024
@JosePizarro3 JosePizarro3 self-assigned this Jul 15, 2024
@JosePizarro3 JosePizarro3 added this to the 0.1.0 milestone Jul 15, 2024
@JosePizarro3
Copy link
Collaborator Author

As a note, this is purely a moving of the class definitions here, not a fix nor we should care too much about the structure right now.

But maybe it is worth to come back to it later along the testing process.

@JosePizarro3
Copy link
Collaborator Author

JosePizarro3 commented Sep 18, 2024

TODO:

(Don't mind the notifications you are having for now)

@JFRudzinski
Copy link
Collaborator

Thanks Chema, I will migrate MD and also take a look at the others that you tagged me on. What is your timeline / priority on this?

@JosePizarro3
Copy link
Collaborator Author

What is your timeline / priority on this?

None, really. I think it depends on what workflows you need to define for your parsers. I want to move SimulationWorkflow, SinglePoint tho, so you can use it from this repo using the new data schema.

@JosePizarro3
Copy link
Collaborator Author

My suggestion: work on the parsers and extend the workflow there, so for debugging it does not feel too complicated. When you are ready, move the schema here

@JFRudzinski
Copy link
Collaborator

ok cool, I think I will move the MD stuff over sooner than later, so that I can integrate with physical properties

@ndaelman-hu
Copy link
Collaborator

I'm confused: wasn't this what we were going to discuss 1st week of Oct.?

@JFRudzinski
Copy link
Collaborator

I think that is more for discussing restructuring of the workflow schema. We had already decided before that we would move it into nomad-simulations (or at least that was my understanding)

@JosePizarro3
Copy link
Collaborator Author

Our discussion in Oct is going to be mainly about Activity vs Workflow, but we will touch this part too. I just needed a place where to put which classes we need to transfer from simulationworkflowschema to here, but you don't need to work on this yet if you don't want to.

I'll let you know once the SinglePoint is already merged.

@JFRudzinski JFRudzinski modified the milestones: 0.1.0, 1.0.0 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
3 participants