-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving simulation workflow definitions to this repo #100
Comments
As a note, this is purely a moving of the class definitions here, not a fix nor we should care too much about the structure right now. But maybe it is worth to come back to it later along the testing process. |
TODO:
(Don't mind the notifications you are having for now) |
Thanks Chema, I will migrate MD and also take a look at the others that you tagged me on. What is your timeline / priority on this? |
None, really. I think it depends on what workflows you need to define for your parsers. I want to move |
My suggestion: work on the parsers and extend the workflow there, so for debugging it does not feel too complicated. When you are ready, move the schema here |
ok cool, I think I will move the MD stuff over sooner than later, so that I can integrate with physical properties |
I'm confused: wasn't this what we were going to discuss 1st week of Oct.? |
I think that is more for discussing restructuring of the workflow schema. We had already decided before that we would move it into nomad-simulations (or at least that was my understanding) |
Our discussion in Oct is going to be mainly about I'll let you know once the SinglePoint is already merged. |
@ladinesa and the others (@JFRudzinski @ndaelman-hu @Bernadette-Mohr)
I would like to start moving the
SimulationWorkflow
definitions here, under a sub-folderworkflow
in the schema packages defs of this package.I also encountered some issues when releasing the Wannier90 parser in pypi and trying to add the current
nomad-simulation-workflow-schema-plugin
as it does not have a released version. In any case, this would be solved now if we moved everything here.As a reference, this is the repo I will be transfering: https://github.com/nomad-coe/nomad-schema-plugin-simulation-workflow
The text was updated successfully, but these errors were encountered: