Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizer Improvement suggestion #1142

Open
liviozanol opened this issue Nov 22, 2024 · 0 comments
Open

Finalizer Improvement suggestion #1142

liviozanol opened this issue Nov 22, 2024 · 0 comments

Comments

@liviozanol
Copy link

As we know from this previous issue, kopf will fail to send large requests to K8S API (actually k8s API does not support it).

My suggestion is that when removing the finalizer, in fact just send the patch removing the finalizer itself instead of the entire pod spec. That will avoid the failure due to large request....

Ref:

def allow_deletion(

If this was python k8s API it would be something like (if not other finalizer):

               self.v1.patch_namespaced_pod(pod, ns, body={
                    "metadata": {
                        "finalizers": None
                    }
                })
@liviozanol liviozanol changed the title Improvenet suggestion Finalizer Improvement suggestion Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant