Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized selector when event.flyerUrl is null #3

Closed
dbarden opened this issue Jan 11, 2013 · 13 comments
Closed

Unrecognized selector when event.flyerUrl is null #3

dbarden opened this issue Jan 11, 2013 · 13 comments

Comments

@dbarden
Copy link
Contributor

dbarden commented Jan 11, 2013

Whenever we receive an event which has no flyerUrl set, a Unrecognized selector will be thrown at setEvent: in EventCell.

Do we have any kind of default flyer for the events? I think the best way to handle it is to set the default flyer in the server.

@otaviocc
Copy link

I'm using a placeholder image on the iPad app while the flyer download isn't completed (or there's no flyer image for a given event).

PlaceHolder 2x

@ltartari
Copy link
Member

Hipsterize:
PlaceHolder 2x

@otaviocc
Copy link

:-P The flyer should never return NULL. If there's no flyer for the event, it should return a picture of the venue..

@felipecsl
Copy link
Member

We dont have pictures for most venues. I will change the backend to return this placeholder image

Felipe Lima
Sent from my phone

On Friday, January 11, 2013 at 19:54, Otavio Cordeiro wrote:

:-P The flyer should never return NULL. If there's no flyer for the event, it should return a picture of the venue..


Reply to this email directly or view it on GitHub (#3 (comment)).

@otaviocc
Copy link

Is the webapp skipping events without flyers? Because it always shows an image.

@otaviocc
Copy link

Oh, it shows an icon that represents the event type [concert | party].

@ltartari
Copy link
Member

Here's the logic for that on the Web App:

p.flyer or p.venue.image or '/images/app/party-placeholder.png'

… that's for a party.

I believe that the image should stay on the device to make it faster to load. Just my 2¢.

@otaviocc
Copy link

Leo, the problem isn't where the image is, but a null value on the json response. The image will be fetch only once, and then stored in a NSCache instance.

@ltartari
Copy link
Member

Ok, agreed.

The point that I was raising was that the download of a placeholder image should not happen in the first place and that having it stored in-app seems to be more logical. This image should be shown immediately after the data from the JSON is parsed, making the app look snappier. The image would then be replaced after each flyer or venue image is download and it should show as is only in extreme cases [when there's no image for both the event or venue]. I firmly believe that that's the best experience for the user. =)

@otaviocc
Copy link

I see. The placeholder is stored within the iPad app.

The line

p.flyer or p.venue.image or '/images/app/party-placeholder.png'

does not return a placeholder. It returns a fallback image.

placeholder image = ux
fallback image = plan b

@ltartari
Copy link
Member

Humm, that's right. The fallback images are also part of the UX.
Can't they be stored in-app as well? The thing is that we don't have a CDN yet, and serving assets for the mobile clients can be very consuming. Any ideas on that?

@otaviocc
Copy link

Two images (party + concert) that will be downloaded only once per client*? Very consuming? Send a NULL then, and let the client show the placeholder instead.

*events that use the same image will retrieve the image from the local cache. These two images will be downloaded once. There's no reason to keep images on different repositories and different dimensions (retina and non-retina).

@felipecsl
Copy link
Member

Added placeholder images based on iPad version: df05a47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants