-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unrecognized selector when event.flyerUrl is null #3
Comments
:-P The flyer should never return NULL. If there's no flyer for the event, it should return a picture of the venue.. |
We dont have pictures for most venues. I will change the backend to return this placeholder image Felipe Lima On Friday, January 11, 2013 at 19:54, Otavio Cordeiro wrote:
|
Is the webapp skipping events without flyers? Because it always shows an image. |
Oh, it shows an icon that represents the event type [concert | party]. |
Here's the logic for that on the Web App: p.flyer or p.venue.image or '/images/app/party-placeholder.png' … that's for a party. I believe that the image should stay on the device to make it faster to load. Just my 2¢. |
Leo, the problem isn't where the image is, but a null value on the json response. The image will be fetch only once, and then stored in a NSCache instance. |
Ok, agreed. The point that I was raising was that the download of a placeholder image should not happen in the first place and that having it stored in-app seems to be more logical. This image should be shown immediately after the data from the JSON is parsed, making the app look snappier. The image would then be replaced after each flyer or venue image is download and it should show as is only in extreme cases [when there's no image for both the event or venue]. I firmly believe that that's the best experience for the user. =) |
I see. The placeholder is stored within the iPad app. The line
does not return a placeholder. It returns a fallback image. placeholder image = ux |
Humm, that's right. The fallback images are also part of the UX. |
Two images (party + concert) that will be downloaded only once per client*? Very consuming? Send a NULL then, and let the client show the placeholder instead. *events that use the same image will retrieve the image from the local cache. These two images will be downloaded once. There's no reason to keep images on different repositories and different dimensions (retina and non-retina). |
Added placeholder images based on iPad version: df05a47 |
Whenever we receive an event which has no flyerUrl set, a
Unrecognized selector
will be thrown atsetEvent:
in EventCell.Do we have any kind of default flyer for the events? I think the best way to handle it is to set the default flyer in the server.
The text was updated successfully, but these errors were encountered: