-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constant connection to api.github.com, blocked from api #401
Comments
Constant connections and many requests? How many per hour or minute? Noisetorch should check only once when starting. Unless Noisetorch is exited and restarted again and again, this should not happen. |
I actually ran into this issue in March, but didn't open an issue (perhaps by mistake?). At least on my machine, there seems to be an issue with the autorestart behavior as defined in the template systemd unit. When this issue manifests, it results in my IP being rate limited by the GitHub API and noisetorch rendered unusable (as well as a bunch of other tools I rely on). I'm not sure what causes the initial rate limiting, but having the noisetorch service ping GitHub every 3 seconds while you are rate limited certainly doesn't help... My solution for the last 5 months or so has been to simply manually remove this autorestart behavior on my own machine. |
Describe the bug
Noisetorch seemingly sends so many requests to
140.82.121.6 and lb-140-82-114-26-iad.github.com
which belong to github.It's probably because in update.go it contacts
https://api.github.com/repos/noisetorch/NoiseTorch/releases/latest
GitHub has a limit of 60 API calls per hour for unauthorized users.
I only noticed this behavior because my system always downloaded/uploaded a few kb (5~6kb)
and
sudo tcpdump -i nameofinteface
showed some random requests to the ip address mentioned aboveand programs like ProtonUp-Qt which rely on GitHubs API break.
To Reproduce
Steps to reproduce the behavior:
Maybe a button for manually updating is better?
The text was updated successfully, but these errors were encountered: