Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to complete donations on iOS, expiration date validation error #49

Open
danasf opened this issue Sep 26, 2022 · 0 comments
Open

Comments

@danasf
Copy link

danasf commented Sep 26, 2022

Credit card expiration date validation fails on iOS preventing mobile users from making donations. This can be easily replicated on the donation page with mobile, or with a desktop browser if you omit the /

cc-exp has inputmode="numeric", the javascript seems to be expecting a / to split month and year, but you cannot enter this character thus leading to a validation error.

  exp_month: $form.find(".cc-exp").val().split("/")[0],
  exp_year: $form.find(".cc-exp").val().split("/")[1]

Beyond this, the form appears to be using a deprecated Stripe.js component, it may be worth considering a move to the Payment Element for support of non-card payment methods and mobile payments like Apple / Google Pay. This would require some back-end changes due to updates in the Stripe API (a move from Tokens->Charges to PaymentIntents).

I have too much on my plate for the next month or two, but if the issue remains unaddressed at that point may take a crack at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant