Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LSP): use generic self type to narrow down methods to complete #6617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(LSP): use generic self type to narrow down methods to complete #6617

wants to merge 1 commit into from

Conversation

asterite
Copy link
Collaborator

Description

Problem

Resolves #6608

Summary

I didn't know about having to use find_matching_method when looking up methods, so back then I ended up doing some similar logic that wasn't quite right.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite requested a review from a team November 25, 2024 17:28
aakoshh
aakoshh approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakoshh aakoshh aakoshh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP suggest unavailable methods
2 participants
@asterite @aakoshh