You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently do not deduplicate any intrinics which have side effects. This results in us not deduplicating instrinsics which we should be able to (example given in #6527 where we do not deduplicate Intrinsic::ToRadix calls of the same variable in the same block).
We essentially need to make deduplication of these instructions aware of deduplicate_with_predicate similarly to how we do for other instructions.
The text was updated successfully, but these errors were encountered:
TomAFrench
changed the title
Deduplicate intrinsics with side effects if
Deduplicate intrinsics with side effects they're under the same predicate
Nov 15, 2024
We can add the && deduplicate_with_predicate clause but we also need to actually match on them more closely in that case since we still wouldn't want to deduplicate e.g. println(1)
TomAFrench
changed the title
Deduplicate intrinsics with side effects they're under the same predicate
Deduplicate intrinsics with side effects when they're under the same predicate
Nov 18, 2024
We currently do not deduplicate any intrinics which have side effects. This results in us not deduplicating instrinsics which we should be able to (example given in #6527 where we do not deduplicate
Intrinsic::ToRadix
calls of the same variable in the same block).We essentially need to make deduplication of these instructions aware of
deduplicate_with_predicate
similarly to how we do for other instructions.The text was updated successfully, but these errors were encountered: