Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine ACVM and Nargo bitsize checks #5985

Open
michaeljklein opened this issue Sep 9, 2024 · 0 comments
Open

Combine ACVM and Nargo bitsize checks #5985

michaeljklein opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@michaeljklein
Copy link
Contributor

Problem

Running ACVM bitsize checks that throw errors prevent existing Nargo errors for addition and bitwise operations from being thrown:

  • ACVM error: FunctionInput value has too many bits..
  • Nargo error: attempt to add with overflow

To prevent this regression, bitsize checks introduced in #5864 are disabled for:

  • Bitwise operations
  • Range check operations

See discussion for more details.

Happy Case

  • When an attempt to .. with overflow error is thrown, catch and validate the associated ACVM too many bits error
  • Re-enable bitwise and range operation bitsize checks in ACVM
    • Remove the skip_bitsize_checks parameter from input_to_value in ACVM

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Nice-to-have

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant