Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Next.js Actions cache? #5353

Closed
targos opened this issue May 3, 2023 · 4 comments
Closed

Problem with Next.js Actions cache? #5353

targos opened this issue May 3, 2023 · 4 comments

Comments

@targos
Copy link
Member

targos commented May 3, 2023

See #5352
No cache was found on Windows (but it was found on Linux): https://github.com/nodejs/nodejs.org/actions/runs/4873873254/jobs/8694059608

@targos
Copy link
Member Author

targos commented May 3, 2023

That said, it doesn't seem like the cache helps a lot. My PR only added a page, but the build took 3m35s on Linux with cache and 3m50s on Windows without cache.

@AugustinMauroy
Copy link
Contributor

don't worry on redesign branch we use turbo and it's great

@ovflowd
Copy link
Member

ovflowd commented May 3, 2023

@targos I guess even by restoring the cache, Next.js did not use that cache (for some reason). But yes, on the major/website-redesign we made a lot of changes that should speed up the build process.

Also the cache is done by a combination of branch-name, package-lock and other factors.

@AugustinMauroy
Copy link
Contributor

@targos We just update CI normally it's good

@targos targos closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants