assert: make partialDeepStrictEqual work with urls and File prototypes #56231
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
BridgeAR
approved these changes
Dec 11, 2024
BridgeAR
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56231 +/- ##
==========================================
- Coverage 88.54% 88.52% -0.02%
==========================================
Files 657 657
Lines 189899 189975 +76
Branches 36465 36488 +23
==========================================
+ Hits 168140 168170 +30
- Misses 14966 14994 +28
- Partials 6793 6811 +18
|
tonivj5
reviewed
Dec 11, 2024
test/parallel/test-assert-objects.js
Outdated
| @@ -271,6 +271,16 @@ describe('Object Comparison Tests', () => { | |||
| actual: { dataView: new Uint8Array(3) }, | |||
| expected: { dataView: new DataView(new ArrayBuffer(3)) }, | |||
| }, | |||
| { | |||
| describe: 'throws when comparing Float32Array([+0.0]) with Float32Array([-0.0])', | |||
There was a problem hiding this comment.
Suggested change
| describe: 'throws when comparing Float32Array([+0.0]) with Float32Array([-0.0])', | |
| description: 'throws when comparing Float32Array([+0.0]) with Float32Array([-0.0])', |
There was a problem hiding this comment.
🤦 this must have been the autocomplete ... thanks 😄
puskin94
force-pushed
the
partial-deep-strict-equal-missing-cases
branch
from
40e6cba to
943cb6d
Compare
jasnell
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR should close the gap between
assert.deepStrictEqualandassert.partialDeepStrictEqualeven more.Found a couple more cases that were not properly working:
Object.getPrototypeOf(File.prototype)andBlob.prototypenew Float32Array([+0.0])andnew Float32Array([-0.0])were considered equal, which is not the case