New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between dynamic and static imports in loader hooks #204

Open

thetutlage opened this issue Jun 22, 2024 · 1 comment

thetutlage commented Jun 22, 2024

We have a very specific use-case for ESM loader hooks that we are using here with https://github.com/Julien-R44/hot-hook

hot-hook is an ESM loader that enables HMR for Node.js apps without performing any bundling or static analysis of the code.

However, hot-hook can only work with dynamic imports and hence it becomes super crictical for us to differentiate between static and dynamic imports.

Since, loader hooks are under active development, we thought to share our use-case and see if it makes broader sense for Node.js to support this.

Member

GeoffreyBooth commented Jun 22, 2024

Related: #205

RomainLanz mentioned this issue

feat: throw if HMR is enabled and controller is directly imported adonisjs/http-server#85

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment