-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install process is broken/unsafe #38
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You can't yarn install (or npm install) in a postinstall script. It's not safe.
Yarn e.g. is unsafe to use (when hitting its cache, such as install, add, upgrade, ...) concurrently. Yarn runs multiple postinstall scripts in parallel, and if multiple packages do 'yarn install', the cache (hence packages) can become corrupt.
I've gotten around this by wrapping yarn and adding a host-level mutex around it, but then I can't install anything that depends on full-icu.
Consider a different approach.
Plus, you're bypassing yarn's/npm's own dependency graph optimization/flattening.
The text was updated successfully, but these errors were encountered: