Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CITGM status - v17 #885

Closed
targos opened this issue Dec 6, 2021 · 3 comments
Closed

CITGM status - v17 #885

targos opened this issue Dec 6, 2021 · 3 comments

Comments

@targos
Copy link
Member

targos commented Dec 6, 2021

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1121/

@targos
Copy link
Member Author

targos commented Dec 6, 2021

@mcollina @delvedor I'm not sure why fastify still fails: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1121/nodes=ubuntu1804-64/testReport/junit/(root)/citgm/fastify_v3_24_1/

It says "# failed 5 of 96 tests" but I see no test with a "not ok" output.

There's also this at the end of the logs:

 FakeTimers: clearTimeout was invoked to clear a native timer instead of one created by this library.
 To automatically clean-up native timers, use `shouldClearNativeTimers`.
 (node:5020) [FSTDEP009] FastifyDeprecation: You are using a custom route versioning strategy via the server { versioning: "..." } option, use { constraints: { version: "..." } } option instead.
 (Use `node --trace-warnings ...` to show where the warning was created)
 ERROR: Coverage for lines (99.94%) does not meet global threshold (100%)
 ERROR: Coverage for functions (99.67%) does not meet global threshold (100%)
 ERROR: Coverage for statements (99.94%) does not meet global threshold (100%)

@mcollina
Copy link
Member

mcollina commented Dec 6, 2021

The node v17 fixes are not released yet. They will be in the next release (or sooner if @delvedor beat me to it)

@BethGriggs
Copy link
Member

@targos should we close this as the test run linked is no longer accessible? (I'm hoping #894 will pick up some of the general flakes/platform issues that apply across multiple versions.)

@targos targos closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants