Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Editor Compatibility #13

Open
sammachin opened this issue Jan 24, 2022 · 3 comments
Open

Check Editor Compatibility #13

sammachin opened this issue Jan 24, 2022 · 3 comments

Comments

@sammachin
Copy link
Collaborator

Test for compatibility with the Monaco editor

@Steve-Mcl
Copy link

The issue was an old (but well used) node-red contrib node was duplicated (and modified) by several users to create new nodes. The original contrib node had a copy of multiple-select.js (V1.4.2) embeded in its src (rather than required

While it might prove difficult to test for this embeded js file & its version, we can certainly check for installs of the below nodes where version is < the version of the known fix for these items?

@sammachin
Copy link
Collaborator Author

So if we were checking a new node outside of a Node-RED install we would need to look for that multiple-select.js file in the static folder?

What about if the node is fetching it externally, can it come from npm? or is it a CDN thing?

@Steve-Mcl
Copy link

What about if the node is fetching it externally, can it come from npm? or is it a CDN thing?

If we can check the version is > 1.4.2 then it is ok (as we can with a NPM and sometimes a CDN if it is encoded in the name or meta data is available).

If we find a file in a static folder named multiple-select.js then perhaps a warning unless we know the package to by updated (as above)?

In fact, static files are prone to falling behind the original repo/package (assuming they are a copy of an actual package as this one is) - hmmmm - can-o-worms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants