Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Parse paletteLabel and align #8

Open
codmpm opened this issue Mar 21, 2017 · 4 comments
Open

Enhancement: Parse paletteLabel and align #8

codmpm opened this issue Mar 21, 2017 · 4 comments

Comments

@codmpm
Copy link

codmpm commented Mar 21, 2017

It would be nice to reflect the properties set by paletteLabel and align from the nodes in _palettenode.html so that the look is the same as in the palette in node-red's editor.

flows.nodered.org
flow-nodered-org-node-visualisation

in comparison to the palette
palette-node-visualisation

@codmpm codmpm changed the title Enhancement: Parse paletteLabel and align Enhancement: Parse paletteLabel and align Mar 21, 2017
@yoiang
Copy link

yoiang commented Jan 5, 2019

If an owner could verify that the paletteLabel should be used and the type name isn't being shown for a specific reason I can make a PR with the change.

@knolleary
Copy link
Member

paletteLabel should not be used. We display the type name as that is important information to share about the module.

@yoiang
Copy link

yoiang commented Jan 5, 2019

@knolleary for argument's sake, we don't want to show the end user a preview of what they would expect to see in their own editor? Will it be confusing that once the nodes turn up in the editor some are prepended with ui_ and some aren't?

@knolleary
Copy link
Member

There's a balance to be struck between two different requirements; displaying the node as it appears in the palette, and listing the underlying node type.

Open to suggestions for addressing both.

@knolleary knolleary reopened this Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants