-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnttecUSBDMXPRO driver: SerialPort "writable" property no longer exists? #80
Comments
Good catch, in the documentation of the serial port version 7.x.x we are using there is also no mention of But I'm wondering: if |
It is coming from the stream writable and still exists :) |
In the sendUniverse method, it checks the "writable" property:
I think that it should be checking SerialPort.isOpen property instead? I can't find the writable property in the current SerialPort documentation: https://serialport.io/docs/en/api-stream
I found this while debugging a memory leak when testing an animation to be sure my app wouldn't crash if it couldn't find an Enttec device. If testing for 'writable', the driver will write to a non-existent serial port, leak memory, and eventually crash. When I changed the driver code to this, it seems to run ok:
The text was updated successfully, but these errors were encountered: