Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Package Download in pkgci_shark_ai.yml #804

Open
renxida opened this issue Jan 9, 2025 · 0 comments
Open

Simplify Package Download in pkgci_shark_ai.yml #804

renxida opened this issue Jan 9, 2025 · 0 comments

Comments

@renxida
Copy link
Contributor

renxida commented Jan 9, 2025

Comments from Scott on #780

I'd like to simplify these steps as we add more pkgci_*.yml workflows, but this is fine for now.

For the downloads, actions/download-artifact supports downloading multiple artifacts using some pattern: https://github.com/actions/download-artifact?tab=readme-ov-file#download-multiple-filtered-artifacts-to-the-same-directory . Could try with

pattern: snapshot-*-cp${{ env.PY_VERSION_NO_DOT }}-*

Note that sharktank and shark-ai aren't dependent on Python versions, and audit_wheel actually removes the cp311 from the names:
image

So if we keep the versions in the names, we can have a single download step that filters. If we remove the versions, we could either download all artifacts (no filtering at all) or two download steps, one that filters for cp311 and one that filters for py3-none.

For the PY_VERSION_NO_DOT, I don't see a way to get actions/setup-python to use the cp311 syntax: https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md.

The downloads are fast (less than 10MB total, taking seconds or less), so I'd probably just download all artifacts then make sure setup_venv.py respects the selected Python version and only tries to install compatible packages from the download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant