Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling cancel blocks the controller #88

Open
rokusottervanger opened this issue Feb 23, 2022 · 0 comments
Open

Calling cancel blocks the controller #88

rokusottervanger opened this issue Feb 23, 2022 · 0 comments

Comments

@rokusottervanger
Copy link
Contributor

A call to cancel should return whether or not the controller implements stopping behavior. If false, the base class handles it (and outputs a zero velocity setpoint right away). Meaning we should not block, but return true immediately, in this case.

Source: https://github.com/magazino/move_base_flex/blob/a5c19cb8f3135679e4f8f36a9ec6123b121d69ab/mbf_abstract_nav/src/abstract_controller_execution.cpp#L257-L259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant