Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path_tracking_pid::PidConfig config_ should be decoupled from dynamic reconfigure #129

Open
Timple opened this issue Mar 9, 2022 · 0 comments
Labels
refactor Refactor request

Comments

@Timple
Copy link
Member

Timple commented Mar 9, 2022

dynamic reconfigure is an implementation of ROS which happens to use a large struct for its parameters.

However some of these we don't like to have dynamically reconfigurable.

I propose to have an own struct with the parameters. And let the path_tracking_pid::PidConfig config be local to the reconfigure callback. In this callback we can (if approved) set the controller parameters with setters.

This might allow to switch to ddynamic_reconfigure (if we want to). Also allows for easier ROS2 transition in the future (it uses a different method for dynamic reconfigure behavior).

@Timple Timple added the refactor Refactor request label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor request
Projects
None yet
Development

No branches or pull requests

1 participant