Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of method has and impact on Nearley parser #158

Open
houghtonap opened this issue May 27, 2021 · 1 comment
Open

Deprecation of method has and impact on Nearley parser #158

houghtonap opened this issue May 27, 2021 · 1 comment

Comments

@houghtonap
Copy link

In version 0.5.0, it appears that moo deprecated method has and it now always returns true. Since the Nearley parser uses method has, the code it generates now always succeeds producing incorrect results. While I do understand that the moo project has a right to deprecate their interfaces, I'm wondering whether the impact to the Nearley parser was taken into consideration? Also, what was the reason for deprecation of the method has, for example, did it not work correctly in the update from v0.4.3 to v0.5.0 hence it's deprecation because moo internals changed and it could no longer be supported? Would the v0.4.3 code for the method has still work, if I hacked it back into the source for the latest version of moo? Thx.

@tjvr
Copy link
Collaborator

tjvr commented May 29, 2021

Hey! You can see more context on this change here: #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants