[Event] Add new event type #225
Conversation
gichan-jang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung and
anyj0527
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #225. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
gichan-jang
force-pushed
the
event/connected
branch
from
7f92b0c
to
4d8b56b
Compare
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
gichan-jang
force-pushed
the
event/connected
branch
from
4d8b56b
to
75d5052
Compare
Add new event type for new connection. Signed-off-by: gichan2-jang <[email protected]>
gichan-jang
force-pushed
the
event/connected
branch
from
75d5052
to
288a464
Compare
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
| @@ -30,6 +30,7 @@ typedef enum { | |||
| NNS_EDGE_EVENT_NEW_DATA_RECEIVED, | |||
| NNS_EDGE_EVENT_CALLBACK_RELEASED, | |||
| NNS_EDGE_EVENT_CONNECTION_CLOSED, | |||
| NNS_EDGE_EVENT_CONNECTION_COMPLETED, | |||
There was a problem hiding this comment.
Does this message indicate that the network connection was successfully (completed)established? Or does it mean that the network connection is active?
There was a problem hiding this comment.
It means that the network connection was successfully established.
If network connection status is changed to inactive, NNS_EDGE_EVENT_CONNECTION_CLOSED event will be invoked.
There was a problem hiding this comment.
Thank you for the detailed explanation. 🙏
Add new event type for new connection.
Self evaluation: