Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Queue] change param #218

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[Queue] change param #218

merged 1 commit into from
Aug 26, 2024

Conversation

jaeyun-jung
Copy link
Collaborator

Change function param, return error code when getting queue len.

@taos-ci
Copy link
Collaborator

taos-ci commented Aug 23, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #218. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Aug 23, 2024

:octocat: cibot: @jaeyun-jung, src/libnnstreamer-edge/nnstreamer-edge-internal.c includes bug(s). Please fix incorrect coding constructs in your commit before entering a review process.

taos-ci
taos-ci approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

gichan-jang
gichan-jang approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@gichan-jang gichan-jang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeyun-jung
[Queue] change param
ed13869 
Change function param, return error code when getting queue len.

Signed-off-by: Jaeyun Jung <[email protected]>
taos-ci
taos-ci approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

@jaeyun-jung jaeyun-jung merged commit 95fed22 into nnstreamer:main Aug 26, 2024
32 checks passed
@jaeyun-jung jaeyun-jung deleted the queue-fix-ret-code branch August 26, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gichan-jang gichan-jang gichan-jang approved these changes

@taos-ci taos-ci taos-ci approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeyun-jung @taos-ci @gichan-jang