Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in the stripInvalidFaceWorker() function #203

Open
jiafulow opened this issue Dec 28, 2024 · 0 comments
Open

Possible typo in the stripInvalidFaceWorker() function #203

jiafulow opened this issue Dec 28, 2024 · 0 comments

Comments

@jiafulow
Copy link

Hi,

I noticed a possible typo in the function SimplePolygonMesh::stripInvalidFaceWorker() where the parameter removeLowDegree is unused (meanwhile removeWithBadInds is doubly used).

// Test faces with degree < 3
if (removeWithBadInds) {
if (face.size() < 3) {
cullFace = true;
}
}

I think, on Line 549, that should be removeLowDegree instead of removeWithBadInds.

I don't believe this is causing any real issues. So, it' really a very minor type—just thought I’d point it out! Thanks for all your hard work in building this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant