Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up warnings in user-example files #30

Open
e-perl-NOAA opened this issue Nov 1, 2023 · 1 comment
Open

Clean up warnings in user-example files #30

e-perl-NOAA opened this issue Nov 1, 2023 · 1 comment
Assignees
Labels
model files Changes or additions to model files

Comments

@e-perl-NOAA
Copy link
Collaborator

See issue #51 in the test-models repos. The models in the user-examples repo have some warnings that didn't exist (or related to model options that didn't exist) when the models were created. In most cases, the models should be changed to make the warnings go away. This will make it easier to see when new warnings appear in the future. In a few cases, the warnings themselves may need revision in the SS3 code.

Warning files for these models aren't included in the model files like they are for the test models so a text file of each warning file is included below:
empirical_wtatage_and_age_selex
selex_age_example
selex_length_example
simple
simple_long
simple_long_wtatage
simple_with_discard

@e-perl-NOAA e-perl-NOAA added the model files Changes or additions to model files label Nov 1, 2023
@Rick-Methot-NOAA
Copy link
Collaborator

In some cases the warnings were created because some models were not using good practices. So this current effort to reduce warnings is also accomplishing the goal of updating examples to use good practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model files Changes or additions to model files
Projects
None yet
Development

No branches or pull requests

3 participants