Don't use absolute dir for mkbootimg symlink #137
Conversation
|
Your change contains 2 set of modifications - cmake file cleanup, and the relative symlink change itself.
Once you apply the cmake cleanup part, what is the target's absolute path for that symlink? I wonder if your cleanup part is enough to fix the issue. |
I can separate those changes.
RPM does like not like relative symlinks as they relative to the host environment and not to the builder which breaks for example the execution inside the built process. To check if the script still works we start it once which doesn't work with an absolute link. |
|
Something like this would be welcomed for the Snap release. Right now I'm replacing the symlink in a post-installation step during packaging. |
|
@Thaodan could you please split your change into multiple commit per its functionality: one commit for the symlink change, and another commit for the cleanup? |
|
@Biswa96 the PR is ready for merge. Could you please take a look? |
…ative bin Now the bin directory can be changed using standard cmake means. Signed-off-by: Björn Bidar <[email protected]>
I noticed that the absolute symlink did not work on my system when trying to execute the script inside it's installation directory before the package is installed. While investigating I noticed that on SUSE the symlink gets relinked to be relative to be relative to the install location of the symlink after which the link works. Using a relative link seems safer to me. Signed-off-by: Björn Bidar <[email protected]>
Thaodan
force-pushed
the
symlink_mkbootimg
branch
from
1804c95
to
0983183
Compare
I noticed that the absolute symlink did not work on my system.
While investigating I noticed that on SUSE the symlink gets relinked
to be relative to be relative to the install location of the symlink
after which the link works.
Using a relative link seems safer to me.