Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow model piping within a multi-target #19

Closed
billdenney opened this issue Mar 16, 2024 · 2 comments · Fixed by #22
Closed

Allow model piping within a multi-target #19

billdenney opened this issue Mar 16, 2024 · 2 comments · Fixed by #22

Comments

@billdenney
Copy link
Collaborator

Allow automatic detection of being in the same target to allow the model to be found, chosen, and passed into a pipe.

@mattfidler
Copy link
Member

This is what I was going to test for in the review. Let me know when this is done so I can test it and look to see if it is working well.

@billdenney
Copy link
Collaborator Author

@mattfidler, I just merged the changes for this. It should now work with model piping within a multiple-model fitting call. It should also detect circular (or hanging) references to models that do not exist or cannot be created.

I added it to the vignette: https://nlmixr2.github.io/nlmixr2targets/articles/estimating.html#model-piping-for-multiple-models-estimated-with-one-dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants