-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBFLToPEFStep after 10 iterations: Failed to complete volume division #68
Comments
This may happen because of several reasons. It may happen when the volume breaking algorithm can't find a solution. But I also remember I found a bug once that made Dotify think it needed to do more iterations while it wasn't needed. |
I haven't found whether I was actually managed to fix this bug, but I may have. I'll let you know when the particular commit is pushed. |
@josteinaj Is there a test for this checked in. Or do you want to try it manually? I haven't pushed that possible fix yet because it is part of that "shift-id" fix. I can push it if you want to test. |
I found the book where it last happened. And it happened again when I ran it now. Uploaded it to our Slack channel. Feel free to push the shift-id fix. |
Thanks. I can first test it myself now. Any specific non-default options I have to set? |
I think everything is default.
|
@josteinaj There is a file missing: stylehyphenation.css. |
But not sure if it's important. I can reproduce the issue without. |
This has to do with the fact that the generated TOC references the This results in an invalid OBFL but at the moment there is no OBFL validation yet (see daisy/pipeline-mod-braille#151). A bit related: sbsdev/pipeline-mod-sbs#60 (comment) |
Not sure how to fix this. Probably not possible to fix in CSS. I think we have to remove the TOC entry |
Test here might be related: pipeline/modules/nlb/book-to-pef/src/test/xprocspec/test_dtbook-to-pef_volume-breaking.xprocspec Line 83 in 6c17ab8
|
Don't see how it's related to the test. Or to automatic volume breaking (don't be mislead by the error message). |
It looks like the test you referenced is similar to the volume-break-before issue in #63. |
OK I guess you mixed up the tests. However the other test is also not related I think (even thought the error message is the same). I'll have a look. |
@josteinaj The test expects a table-of-contents to be inserted in every volume but the maximum number of sheets per volume is set to "1". This can never work. |
Ok, I see. I'll try increasing the volume size. Thanks! |
I've updated the volume breaking tests. The tests now uses 4 sheets. I've also added a Test here: pipeline/modules/nlb/book-to-pef/src/test/xprocspec/test_dtbook-to-pef_volume-breaking.xprocspec Line 115 in 4ec4603
The error below occurs only when the Exception here:
|
Thanks. |
I think we can close this issue now. After all of @bertfrees' fixes, volume breaking seems to work pretty well. |
Not sure what input causes it yet...
The text was updated successfully, but these errors were encountered: