Add index version 4 for distinct records with identical url & date #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gated behind a feature flag as the upgrade process has not been implemented yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gated behind a feature flag as the version 3 to 4 upgrade process has not been implemented yet. To try the index format use command-line flag
--index-version 4.Warning: Using this on a version 3 index will only work partially. Queries will probably work but version 3 records cannot be deleted and updating them will create duplicates.
There may be a better way to encode the v4 keys (suggestions?). It's made awkward by the fact the urlkey field in v0 keys is't terminated we rely on the timestamp always being a fixed 8 bytes to calculate the length of it.
The reason I make the v4 keys a simple extension of the v0 keys is so that querying should work correctly for indexes with mixed record versions. This gives us a pathway to incremental upgrading without extensive downtime.
See additional discussion in #77