Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node forgets configured 1-wire address if node edited too quickly #15

Open
colinl opened this issue Mar 4, 2017 · 2 comments
Open

Node forgets configured 1-wire address if node edited too quickly #15

colinl opened this issue Mar 4, 2017 · 2 comments

Comments

@colinl
Copy link
Contributor

colinl commented Mar 4, 2017

If the node is configured to read from a 1-wire address then later the edit window is opened and Done is clicked before the device list has time to refresh then the configuration is lost.
This can happen if the node is configured to use a remote server as sometimes that can take a few seconds to refresh, it happened to me when I made a small change to the node name on a remote device with a lot of connected sensors
It is easily repeatable if the server is remote and it is made inaccessible by disconnecting the network, for example. It also happens, I suspect, though not tested, if the sensor is temporarily inaccessible while the node is edited.

@njh
Copy link
Owner

njh commented Mar 5, 2017

Yes, I have experienced this as well.

It is also a related issue if there is a slightly dodgy sensor that comes/goes.

Do you have a suggested fix?
Merge the previously 'selected' nodes with the results of the remote query?

@colinl
Copy link
Contributor Author

colinl commented Mar 5, 2017

The solution is not obvious I agree. It can't just merge them otherwise there would be no way of removing nodes after changing a sensor for example.
On closing could it check to see if any of the previously selected nodes are missing from the scan and ask for confirmation that they should be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants