Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic retry on read error #16

Open
njh opened this issue Oct 18, 2016 · 8 comments
Open

Automatic retry on read error #16

njh opened this issue Oct 18, 2016 · 8 comments

Comments

@njh
Copy link
Owner

njh commented Oct 18, 2016

Hello,

I used your owfs library inside my Node-RED owfs node:
https://github.com/njh/node-red-contrib-owfs

I have a feature request to perform automatic retries, when there is an occasional error - in particular when the special value of 85 is read from a DS18B20. I have been trying to seperate concerns, and only include code relating to Node-RED and its UI in my module

Would you accept a Pull Request that adds this functionality to your library?
It would involve somehow passing a retries and interval values, when creating the client.

nick.

@njh
Copy link
Owner Author

njh commented Nov 5, 2016

Any thoughts on this? Would we be wasting our time to send a Pull Request?

@njh
Copy link
Owner Author

njh commented Nov 29, 2016

ping

@benediktarnold
Copy link
Collaborator

Sorry for such a late response. I am currently not very motivated to maintain this package since I don't use it myself. We have two options

  1. I would accept your PR without any questions
  2. I could add you as an npm owner or transfer the package ownership completely to you. This is imho the best Solution since your node-red contribution is the biggest user.

@njh
Copy link
Owner Author

njh commented Dec 12, 2016

Thanks for getting back to me @benediktarnold
Totally understand about lack motivation of maintaining something that you aren't using.

I have a lot of 1-wire devices connected to various Node-RED instances...
If you would transfer the Github repo and npm ownership to me, I promise to look after it!

@benediktarnold
Copy link
Collaborator

benediktarnold commented Dec 13, 2016

@njh I added you as an owner in npm. You should be able to publish releases from now on.

The github repo can't be transferred since you already have a fork. If you delete your fork, the transfer should be possible.

@njh
Copy link
Owner Author

njh commented Dec 13, 2016

Thanks! I have deleted my Github repo fork now.

@colinl
Copy link
Contributor

colinl commented Dec 31, 2016

@njh Just starting to look at this again (though it will have to be at a fairly leisurely pace due to pressure of other stuff). I see you are in an active development stage at the moment. Maybe best that I wait till you reach a stable point in order to avoid confusion.

@njh
Copy link
Owner Author

njh commented Dec 31, 2016

Yes, probably a good idea.

I am nearly done with tidying up type changes, but maybe #19 and #22 would be good to get sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants