Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the toolchain used to build the main project #305

Open
lenianiva opened this issue Oct 20, 2023 · 6 comments
Open

Specify the toolchain used to build the main project #305

lenianiva opened this issue Oct 20, 2023 · 6 comments

Comments

@lenianiva
Copy link
Contributor

Is there an idiomatic method for specifying the toolchain used for generateCargoNix? Currently I'm using an overlay with oxalica/rust-overlay:

      overlays = [
        (import rust-overlay)
        (self: super: let
          toolchain = super.rust-bin.fromRustupToolchainFile ./rust-toolchain.toml;
        in {
          rustc = toolchain;
        })
      ];
      pkgs = import nixpkgs { inherit system overlays; };
@kolloch
Copy link
Collaborator

kolloch commented Oct 22, 2023

That looks pretty good to me!

Would you mind contributing it to the README.md? It is a bit outdated.

@lenianiva
Copy link
Contributor Author

That looks pretty good to me!

Would you mind contributing it to the README.md? It is a bit outdated.

Do you want to move the Flake section up to the top? I don't have numbers but I feel like Flake is the more common usage here. I can also add a template using thje example here.

@kolloch
Copy link
Collaborator

kolloch commented Oct 23, 2023

Heyo @vleni,

Yes, I just recently added some information about flake usage. I want to export something nice since ages there but haven't come around to doing it yet.

Feel free to search the README.md for references to flakes and consolidate them in a Flake section in the beginning and then maybe a separate nix-env section?

Not sure how much time you are willing to spend on this, so if you just keep it short and just add a new section that is also fine.

@lenianiva
Copy link
Contributor Author

Heyo @vleni,

Yes, I just recently added some information about flake usage. I want to export something nice since ages there but haven't come around to doing it yet.

Feel free to search the README.md for references to flakes and consolidate them in a Flake section in the beginning and then maybe a separate nix-env section?

Not sure how much time you are willing to spend on this, so if you just keep it short and just add a new section that is also fine.

I added one self-contained flake example in #306. It doesn't involve any installation so I put it in its own section.

@kolloch
Copy link
Collaborator

kolloch commented Oct 28, 2023

Heyo @vleni !

BTW, feel free to add yourself to the Changelog and thanks again!

@lenianiva
Copy link
Contributor Author

@kolloch I think there's a problem: oxalica/rust-overlay#143

The developer of rust-overlay says we should not override nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants