Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for each configured system recurse into .#checks.<system> instead of recursing into .#checks #302

Open
steveej opened this issue Sep 29, 2024 · 3 comments

Comments

@steveej
Copy link

steveej commented Sep 29, 2024

the issue with the current implementation is that it's leads to errors when combined with IFD and non-available builders for the non-native systems.

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2024

That would require some changes in nix-eval-jobs.

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2024

The disadvantage is though that you potentially hide eval errors for other platforms when doing that.

@MagicRB
Copy link
Contributor

MagicRB commented Sep 29, 2024

We need it to be configurable per repo, so it falls under the "per reps settings" thing which ive mentioned in the past. Also we could just ignore any eval errorrs for other than local platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants