From 2eb1ad271a2e81fa865b0b0941d75374ff6a5288 Mon Sep 17 00:00:00 2001
From: Nivi Sarkar <55898241+nivi-apple@users.noreply.github.com>
Date: Tue, 16 Apr 2024 13:16:06 -0700
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---
 src/darwin/Framework/CHIP/MTRDevice.mm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/darwin/Framework/CHIP/MTRDevice.mm b/src/darwin/Framework/CHIP/MTRDevice.mm
index 4f67b17e9c757d..0dda3a1f010e7b 100644
--- a/src/darwin/Framework/CHIP/MTRDevice.mm
+++ b/src/darwin/Framework/CHIP/MTRDevice.mm
@@ -2344,19 +2344,20 @@ - (NSArray *)_getAttributesToReportWithReportedValues:(NSArray<NSDictionary<NSSt
             }
             NSArray * expectedValue = _expectedValueCache[attributePath];
 
-            // Report the attribute if read attribute would get a value that is changing and no expected value exists.
+            // Report the attribute if a read would get a changed value.  This happens
+            // when our cached value changes and no expected value exists.
             if (readCacheValueChanged && !expectedValue) {
                 previousValue = _readCache[attributePath];
                 shouldReportAttribute = YES;
             }
 
-            // Update the readCache with the attribute value.
+            // Now that we have grabbed previousValue, update the readCache with the attribute value.
             _readCache[attributePath] = attributeDataValue;
 
             if (!shouldReportAttribute) {
-
                 // If an expected value exists, the attribute will not be reported at this time.
-                // When the expected value interval expires, the correct value will be reported.
+                // When the expected value interval expires, the correct value will be reported,
+                // if needed.
                 if (expectedValue) {
                     MTR_LOG_INFO("%@ report %@ value filtered - expected value still present", self, attributePath);
                 } else