Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The interface to assign dataset offers several options such repeating images, but the implementation of these options is not functional #26

Open
4 tasks
celprov opened this issue Apr 30, 2024 · 4 comments · May be fixed by #28
Open
4 tasks

The interface to assign dataset offers several options such repeating images, but the implementation of these options is not functional #26

celprov opened this issue Apr 30, 2024 · 4 comments · May be fixed by #28
Labels
bug Something isn't working

Comments

@celprov
Copy link
Collaborator

celprov commented Apr 30, 2024

What happened?

#17 is breaking the implementation of the following options. Those options need either to be deleted from the interface or correctly implemented.

  • Randomize
  • Repeat images
  • Two conditions
  • Blind inspections

What command did you use?

n/a

What version of the software are you running?

latest

How are you running this software?

Local installation ("bare-metal")

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response
@celprov celprov added the bug Something isn't working label Apr 30, 2024
@esavary
Copy link
Member

esavary commented Apr 30, 2024

Could you maybe paste the error you're encountering? It seems to work on my computer, but maybe it occurs with a specific combination of options

@celprov
Copy link
Collaborator Author

celprov commented Apr 30, 2024

This comment is not related to an error; the problem is that even if you check those boxes, it is not guaranteed the images are actually repeated, randomized, or blinded. Those functionalities need to be tested.

@esavary
Copy link
Member

esavary commented May 1, 2024

Ok, I see. Adding tests is definitely a good idea!

This comment is not related to an error; the problem is that even if you check those boxes, it is not guaranteed the images are actually repeated, randomized, or blinded. Those functionalities need to be tested.

@esavary
Copy link
Member

esavary commented May 1, 2024 •
edited
Loading

I've compiled a brief summary of tasks to address this issue. Feel free to add any additional points that may have been overlooked

  • Add tests to tests the functions
  • Ensure that repeating images return a copy of the list of names
  • Remove the option "two conditions"
  • Add test to check pressing the buttons has an effect

This was referenced May 1, 2024
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Add unit tests for resampling functions esavary/qkay
2 participants
@esavary @celprov