Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot cardiac and respiratory signals if available #386

Open
chrisgorgo opened this issue Feb 13, 2017 · 14 comments
Open

Plot cardiac and respiratory signals if available #386

chrisgorgo opened this issue Feb 13, 2017 · 14 comments

Comments

@chrisgorgo
Copy link
Collaborator

Above the carpet plot.

@oesteban oesteban added this to the MRIQC 1.0.1 milestone Feb 13, 2017
@stale
Copy link

stale bot commented Aug 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@oesteban
Copy link
Member

I would add events files to this

/cc @celprov

Credits of the idea to @tsalo, who mentioned this eons ago.

@oesteban
Copy link
Member

@smoia - look at the date this issue was posted.

@m-miedema
Copy link

I'm taking a look at this! I do wonder how much pre-processing might be appropriate for the physiological signals in this context.

@smoia
Copy link

smoia commented May 15, 2024

To compare the signals to a carpet plot, you do need to process them a little.
In the case of ventilation, a rough respiratory variance (here) could be a proper alternative to preprocessing. For pulse/heart rate, you do need peak detection unfortunately.

@m-miedema
Copy link

Yes! We've talked about the difference between adding useful physio info to MRIQC workflow, which will require the preprocessing you mentioned, and emulating the functionality of MRIQC in a separate PHYSIOQC report.

@celprov
Copy link
Collaborator

celprov commented May 15, 2024

@m-miedema in the last physiopy codesprint I participated in, I started trying to plot the events and the physio atop the carpetplotin MRIQC visual report but did not go very far. I worked in this branch https://github.com/celprov/mriqc/tree/enh/plot-events and this branch https://github.com/celprov/mriqc/tree/enh/plot-physio.
However, I had not considered pre-processing of the physiological signals, my idea was first to really just integrate events and physio into the workflow and naively plot them. I stopped at the step of loading the physio file into the workflow.

@smoia
Copy link

smoia commented May 15, 2024

Perhaps useful here, if I remember correctly one of the issue for putting this signal was to find them first. @drombas worked a while back on a way to do so, perhaps he can help?

@celprov
Copy link
Collaborator

celprov commented May 15, 2024

@oesteban had proposed finding the physio file by extracting the bids entities from the fMRI name and reconstructing the physio bids name by replacing the suffix. That is one of my commit in the enh/plot-physio branch 47786ba. But very open to suggestion on how to implement this better.

@oesteban
Copy link
Member

Let's first address nipreps/nireports#120, which is not concerned with finding the data. Once we are able to generate reportlets with physio signals, we can come back to MRIQC and see how these are located (which, trust me, should not be a big deal with pybids).

@smoia
Copy link

smoia commented May 16, 2024

Oh, sorry, let me explain better: I doubt the problem is finding the file they're in, but then finding which channel is which physio signal seemed problematic (if I remember correctly). That's why @drombas was looking at a way to distinguish them.

@oesteban
Copy link
Member

Okay, yes, that may require some extra configuration of MRIQC.

@smoia
Copy link

smoia commented May 16, 2024

At a certain point we were working on it for phys2bids, so if you don't want to have it in MRIQC, I'd be happy to see it implemented in phys2bids (and it's useful for us, since it's a way to check and automatically label the content of the channels)

@m-miedema
Copy link

I think it makes most sense to implement within phys2bids, since the inputs of MRIQC need to be in BIDS format anyways. Ideally what I'm looking to add on to MRIQC is a very preliminary version of a physioprep workflow that generates something similar to the confounds output in fmriprep that can then be quickly read in and plotted by nireports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants