Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle units in all interfaces #786

Open
effigies opened this issue Oct 24, 2017 · 0 comments
Open

Correctly handle units in all interfaces #786

effigies opened this issue Oct 24, 2017 · 0 comments
Labels
effort: medium Estimated medium effort task help wanted impact: low Estimated low impact task refactoring
Milestone

Comments

@effigies
Copy link
Member

Many of our interfaces that use img.header.get_zooms() assume mm+s units, rather than checking get_xyzt_units(), while the NIfTI standard also allows for meters, microns, milliseconds and microseconds. There will eventually be a dataset where this bites us, so we should try to address this before it becomes a real issue.

In the short term, it may make sense to create a helper function that takes an image and returns zooms in mm+s, and just call that instead of img.header.get_zooms() (not sure if this belongs more in fmriprep or niworkflows).

In the long term, I've proposed a new method on NIfTI headers that always returns mm+s (nipy/nibabel#567). We can use that as a template for a get_norm_zooms(img) function.

@effigies effigies added impact: low Estimated low impact task refactoring labels Dec 11, 2017
@oesteban oesteban added the effort: medium Estimated medium effort task label Mar 12, 2019
@oesteban oesteban modified the milestones: 1.4.2, 1.4.3 Jul 9, 2019
@oesteban oesteban modified the milestones: 20.3.0, 21.0.0 Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Estimated medium effort task help wanted impact: low Estimated low impact task refactoring
Projects
None yet
Development

No branches or pull requests

2 participants