-
Notifications
You must be signed in to change notification settings - Fork 16
Migrate packaging to PEP517/8 #127
Comments
Better help: templateflow/python-client#117. The following files in that PR have only stylistic changes and therefore would not apply here:
The following changes respond to a specificity of the python-client project, so do not apply here either:
PLEASE NOTE that Therefore, to accomplish this, we would need to:
|
In nipreps/sdcflows#410, hatch is used, and the usage of setuptools_scm is removed, while templateflow/python-client#117 still relies on it. Is there a preferred approach between the two? (For now, I've applied a similar method as in nipreps/sdcflows#410 in #128 ) |
All of it is correct -- I posted the above post to clarify that adapting to PEP517/18 and using hatch/hatchling are two different issues. I don't have a preference and it can be done all at once as in sdcflows (a bit more messy) or in a two-step approach as the templateflow client. As you prefer (cc @effigies, in case he has a different view). |
In the past, I have done the two-step just for the sake of getting it right and reviewed by others with limited time. If something stops working, it can be hard to figure out which part is causing problems. That said, at this point I've done it enough times I would probably do it in a single shot. So also no strong preference. |
Thanks for the input. Got it, I'll stick with the all-at-once approach. However, if it becomes challenging to review, I'm open to breaking it into two steps. |
What would you like to see added in this software?
For reference: nipreps/sdcflows#410
Do you have any interest in helping implement the feature?
Yes
Additional information / screenshots
No response
The text was updated successfully, but these errors were encountered: