Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsplus.utils.events.strip_events will get recursion error on bad input type #276

Open
shawnboltz opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@shawnboltz
Copy link
Collaborator

shawnboltz commented Nov 12, 2024

This is an easy fix, but I don't have time to do it right this moment so I just wanted to make a note.

Description
Inputting something other than an obspy Catalog or Event to obsplus.utils.events.strip_events with raise a recursion depth error due to inadequate type checking.

To Reproduce
Pass anything to obsplus.utils.events.strip_events other than a Catalog or Event object.

Expected behavior
Should raise a TypeError instead.

Versions (please complete the following information):
Affects all versions.

@shawnboltz shawnboltz added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant