Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df to inventory get response fails on CI #267

Open
d-chambers opened this issue Jul 21, 2023 · 6 comments
Open

df to inventory get response fails on CI #267

d-chambers opened this issue Jul 21, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@d-chambers
Copy link
Member

Description
Currently test_stations_utils.py::TestDfToInventoryGetReponses::test_get_station_client fails in CI, but works locally (on my machine 😉).

This test reaches out to Pascal data services (formally IRIS) to get response information to create an inventory. It works locally but fails in CI. I wonder if Pascal data services gets too many requests from GH actions so it is getting rejected?

Anyway, I am going to kick the can down the road on this one because I know there are other changes coming to PDS soon that we will have to deal with from an ObsPy level.

@d-chambers d-chambers added the bug Something isn't working label Jul 21, 2023
@d-chambers
Copy link
Member Author

It appears our doc build is failing as well related to this issue, see here.

@shawnboltz
Copy link
Collaborator

I think this is a different issue, but wanted to make sure this wasn't also related to #271 , since the timing is about right for when that started being a thing.

@shawnboltz
Copy link
Collaborator

@d-chambers I think this should be fixed now? I tweaked df_to_inventory a while back to be compatible with obspy's change to how they handle the NRL, so those tests should pass now. The solution I had to come up with was less than ideal, but there's not really anything we can do about it.

@d-chambers
Copy link
Member Author

Ok, so the test passes now? Feel free to close if so.

@shawnboltz
Copy link
Collaborator

Ok, so the test passes now? Feel free to close if so.

In theory, yes. In practice, it looks like the CI is broken (specifically it's failing to install obsplus).

@d-chambers
Copy link
Member Author

Oh, that's not good 😟. I will try to take a look later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants