Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drip doesn't exit when run under make... #68

Open
jszakmeister opened this issue Aug 16, 2013 · 1 comment
Open

drip doesn't exit when run under make... #68

jszakmeister opened this issue Aug 16, 2013 · 1 comment

Comments

@jszakmeister
Copy link

I haven't located the source of this problem (and have run out of time to try and track it down), but I do have a simple reproduction recipe.

Here's my Makefile:

helloworld.jar: *.java
    javac -cp . $^
    jar cf $@ $(addsuffix .class,$(basename $^))

helloworld: helloworld.jar
    drip -cp $< HelloWorld

all: helloworld.jar

.PHONY: helloworld

Here's HelloWorld.java:

public class HelloWorld {
    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

When running make helloworld with this setup, "Hello World!" will get printed, but the process doesn't exit until I hit ctrl-c. I'm running under Mac OS X (Snow Leopard) with this version of java:

:: java -version
java version "1.6.0_51"
Java(TM) SE Runtime Environment (build 1.6.0_51-b11-457-10M4509)
Java HotSpot(TM) 64-Bit Server VM (build 20.51-b01-457, mixed mode)
@jszakmeister
Copy link
Author

The issue here might be that the spawned VMs are retaining a handle to make's stdout, stdin, and stderr. I recall running into a similar situation elsewhere (not with drip) where the parent process would fail to exit until the children gave up the handles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant