From cf38403dd83728de852eb0c7aa8841f60ae03abf Mon Sep 17 00:00:00 2001 From: Travis Fields Date: Mon, 10 Feb 2014 11:23:04 -0500 Subject: [PATCH 1/2] Removed validation around wildcard '*' for IP Address Binding to ssl, it is valid and even an example provided by New-WebBinding for powershell --- manifests/manage_binding.pp | 2 +- spec/defines/manage_binding_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/manifests/manage_binding.pp b/manifests/manage_binding.pp index 9951520..efcca28 100644 --- a/manifests/manage_binding.pp +++ b/manifests/manage_binding.pp @@ -24,7 +24,7 @@ if ($protocol == 'https') { validate_re($certificate_name, ['^(.)+$'], 'certificate_name required for https bindings') - if ($ip_address == '*' or $ip_address == '0.0.0.0') { + if ($ip_address == '0.0.0.0') { fail('https bindings require a valid ip_address') } diff --git a/spec/defines/manage_binding_spec.rb b/spec/defines/manage_binding_spec.rb index c06d5ea..a637f15 100644 --- a/spec/defines/manage_binding_spec.rb +++ b/spec/defines/manage_binding_spec.rb @@ -95,7 +95,7 @@ :ip_address => '*', } } - it { expect { should contain_exec('Attach-Certificate-myWebSite-port-443')}.to raise_error(Puppet::Error, /https bindings require a valid ip_address/) } + it { should contain_exec('Attach-Certificate-myWebSite-port-443')} end describe 'when protocol is https and ip address 0.0.0.0' do From f037d08adaaca6c50aae23bd48ec7f4278beb4ee Mon Sep 17 00:00:00 2001 From: Travis Fields Date: Mon, 10 Feb 2014 11:26:52 -0500 Subject: [PATCH 2/2] Version number updated, needs to be rereleased --- Modulefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modulefile b/Modulefile index 397315b..de32a16 100644 --- a/Modulefile +++ b/Modulefile @@ -1,5 +1,5 @@ name 'opentable/iis' -version '0.0.1' +version '0.0.2' author 'opentable' license 'MIT' summary 'Module that will manage IIS for windows server 2008 and above. It will help maintain application pools, sites and virtual applications'