Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate release notes when uploading builds to Firebase/TestFlight #493

Open
minhnimble opened this issue Jul 6, 2023 · 3 comments
Open
Assignees

Comments

@minhnimble
Copy link
Member

Why

As the majorities vote for this feature proposal, it is beneficial to create release notes automatically via the CD pipeline when deploying builds to Firebase/TestFlight.

Acceptance Criteria

Support generating release notes for both of the following cases:

  • after merging a PR to develop (after each story is completed):
    • Sample command: echo "RELEASE_NOTE_CONTENT="$((git log -1 --merges | grep "\[") | grep . && echo "" || echo $(git log -1 --merges --format=%B))""
    • Expected release note:
      Merge pull request #172 from nimblehq/feature/sc-64238-ui-as-a-user-i-can-see-the-updated-color
      
  • after merging a release PR to main (at the end of the sprint):
    • Sample command: echo "RELEASE_NOTE_CONTENT="$(git log --merges --pretty=%B $(git describe --abbrev=0 --tags)..HEAD | grep "\[")""
    • Expected release note:
      [sc-63766] [Integrate] As a user, I can pull to refresh to get the most recent data on the Payment screen [sc-63767] [UI] As a user, I can pull to refresh to get the most recent data on the Payment screen [sc-59154] [sc-60298] [UI + Integrate] As a user, I can see a message if my history is empty [sc-63706] [Integrate] As a user, I see a toast message to understand that the download is in progress [sc-63422] Pin Improve the padding between the horizontal avatar list & the timer info in the Document Detail screen [sc-62943] [UI] As a user, I can see the recent activities on the home screen [sc-63424] Improve the bottom nav bar on the Main screen to show the tab text properly [Chore] Bump app version 0.8.0
      
      

Who Benefits?

iOS Team Leads

@minhnimble minhnimble added this to the 4.7.0 milestone Jul 6, 2023
@minhnimble minhnimble changed the title Generate release notes when creating builds to Firebase/TestFlight Generate release notes when uploading builds to Firebase/TestFlight Jul 6, 2023
@blyscuit blyscuit modified the milestones: 4.7.0, 4.8.0 Aug 9, 2023
@blyscuit blyscuit removed this from the 4.8.0 milestone Sep 7, 2023
@markgravity
Copy link
Contributor

@minhnimble I think we have already done that, right?

@minhnimble
Copy link
Member Author

minhnimble commented Dec 16, 2024

@markgravity right now I believe we only completed the following:

  • after merging a PR to develop (after each story is completed): done ✅
  • after merging a release PR to main (at the end of the sprint): not yet, we are showing the last merge commit message in the release notes, which won't be meaningful for the testers/users when they test the sprint release build ⚠️

@markgravity
Copy link
Contributor

I can see that, let me work on it 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants